Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding an application makes it unavailable #33

Open
HenrikEngen opened this issue Sep 10, 2023 · 3 comments · Fixed by #29
Open

Hiding an application makes it unavailable #33

HenrikEngen opened this issue Sep 10, 2023 · 3 comments · Fixed by #29
Assignees
@petterroea @simsine
Labels
bug Something isn't working

Comments

@HenrikEngen
Copy link
Member

Related to PR #29.
When hiding an application from the crew page, aka. clicking "Hide" inside an application makes is unavailable. You can see it in the "Hidden applications" tab, but you can't open it. If you try to do so, the page will be stuck loading, and you are actually receiving 404 Application not found.

image
image
@HenrikEngen HenrikEngen added the bug Something isn't working label Sep 10, 2023
@HenrikEngen HenrikEngen mentioned this issue Sep 10, 2023
Merged
@HenrikEngen HenrikEngen linked a pull request Sep 11, 2023 that will close this issue
Optimize the application query, and add hide application feature #29
Merged
@petterroea
Copy link
Contributor

Yes. it is hidden.

@petterroea
Copy link
Contributor

It is only unavailable for the user that made it. Another admin is still able to view it. Not going to fix this any time soon.

@petterroea
Copy link
Contributor

We can keep the issue open in case we feel like changing the behavior in the future, it's not like it hurts us to keep track of it as a possible unwanted behavior

@petterroea petterroea reopened this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petterroea petterroea

@simsine simsine

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize the application query, and add hide application feature phoenixlan/phoenixapi-v1
3 participants
@petterroea @HenrikEngen @simsine