Setting vendored_phpcs_path fails with chmod: Operation not permitted

[td-sclemens]

I created this action to add basic code sniffing for pull requests:

name: Code Sniffer

on:
  pull_request:

jobs:
  sniff:
    name: Sniff changed files
    runs-on: my-server
    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          fetch-depth: 2

      - name: Cache Composer dependencies
        uses: actions/cache@v4
        with:
          path: /tmp/composer-cache
          key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}

      - name: Install dependencies
        uses: php-actions/composer@v6
        with:
          php_version: 8.2
          memory_limit: -1
          container_workdir: /app/www
          command: install
          args: --ignore-platform-reqs

      - name: Get changed files
        id: changed-files
        run: echo "changed_files=$(git diff --name-only -r HEAD^1 HEAD | xargs)" >> $GITHUB_OUTPUT

      - name: Sniff changed files
        uses: php-actions/phpcs@v1
        with:
          php_version: 8.2
          vendored_phpcs_path: www/vendor/bin/phpcs
          path: ${{ steps.changed-files.outputs.changed_files }}
          standard: NameOfMyStandard

I liked the possibility to define your own phpcs binary, so the version defined in composer.json is used.

But it fails with this error:

chmod: changing permissions of '/home/runner/_work/name-of-my-project/name-of-my-project/www/vendor/bin/phpcs': Operation not permitted

[td-sclemens]

Also setting multiple files with path fails, as all is put to quotes in the phpcs-action.bash and interpreted as one file with spaces in its name.
It then of course errors with ERROR: The file "file1 file2 file3" does not exist.

[g105b]

Thanks for reporting this issue. I'm just letting you know I've received it and it's on my radar, but I'm currently a bit snowed under with project work, so it'll be a little while to get around to open source contributions.

[lkm]

I've run into this as well. I believe it can be fixed with !5

[lkm]

any chance you could review and possibly merge !5 @g105b ?

[g105b]

Hi @lkm ,

Thank you for your contribution. I hope this resolves the issue. Please can you test by using dev-master? If it works, I will also implement this on the other php-actions repositories.

Thanks again.

[lkm]

@g105b Thanks for that. I did some testing and actually tried it properly this time. The original problem was solved. However, there was an assumption that the override was also a PHAR file which doesn't really make sense since the main reason anybody would want to override this is to us the composer supplied phpcs and enable thirdparty packages alongside it. Please see this PR: #6