Table Representation [MySQL]

[tyrsson]

While digging into a related requirement for a current project of mine I have found some inconsistencies within the lib overall, or at least I think I have.

We essentially have two concrete classes that deals with representing a table or its identifier and several that consume those two.

• Laminas\Db\TableIdentifier
  Most if not all classes that require a constructor argument for a table name (identifier) will accept an instance of this class.
• Laminas\Db\Metadata\Object\TableObject (which is an empty class that extends \AbstractTableObject) currently only accepts a string.

IMO AbstractTable should accept TableIdentifier|string vs just string as its single argument.

As an example of what I'm looking at.

The Ddl CreateTable accepts either a string or a TableIdentifier instance. I would expect that if one is working with the Ddl classes many times they will have a TableObject instance so it would be very handy if CreateTable could simply be passed that instance vs having to call a method on the instance to getName().

I think, maybe, one way to handle this would be to introduce a TableInterface which TableIdentifier and TableObject could both implement. This would probably require a refactor of one or the other existing classes but wanted to propose the idea here and get your thoughts @settermjd @simon-mundy

[tyrsson]

I still need to look and verify what impact this could have on other platforms.

[simon-mundy]

Agree @tyrsson an Interface would be ideal, and yes TableInterface|string for any argument that requires it.