-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump symfony from 6.0 to 6.4 and add support for 7.0 #1326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This require the 5.0 release of DoctrineMongoDBBundle
doctrine/DoctrineMongoDBBundle#784
Something like
"doctrine/mongodb-odm-bundle": "^3.5|^4.3|dev-5.0.x"
could be tried.
exclude: | ||
- php: '7.4' | ||
symfony_version: '6.2.*' | ||
- php: '7.4' | ||
symfony_version: '6.3.*' | ||
- php: '8.0' | ||
symfony_version: '6.2.*' | ||
- php: '8.0' | ||
symfony_version: '6.3.*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to keep exclude for SF 6.4 and SF 7, because
- SF 6.4 doesn't work on php 7.4 and 8.0
- SF 7 doesn't work on php 7.4, 8.0 and 8.1
@snapshotpl are you make the changes to this branch with the feedback? Or what is your planning? |
@VincentLanglet I waiting for this future. So, I have fix your comments in a PR to the code of snapshotpl. And If snapshot react not quick. Is it then better to make a new PR? |
It seems better indeed because there is still a lot of work. If you open a PR, unfortunately I think the CI will need approval to run. (I don't have this issue cause I already contributed). |
I have make an own #1331 |
any update on this? |
No description provided.