Merge pull request #2 from php-static-analysis/codex/review-code-and-suggest-improvements

Store attribute constructor parameters

Author: carlos-granados

composer.json

@@ -20,14 +20,14 @@
         "php": ">=8.1"
     },
     "require-dev": {
-        "php-static-analysis/node-visitor": "^0.4.1 || dev-main",
-        "php-static-analysis/phpstan-extension": "^0.4.1 || dev-main",
-        "php-static-analysis/psalm-plugin": "^0.4.1 || dev-main",
+        "php-static-analysis/node-visitor": "^0.5.0 || dev-main",
+        "php-static-analysis/phpstan-extension": "^0.5.0 || dev-main",
+        "php-static-analysis/psalm-plugin": "^0.5.0 || dev-main",
         "phpstan/extension-installer": "^1.3",
         "phpstan/phpstan": "^2.0",
         "phpunit/phpunit": "^9.0",
         "symplify/easy-coding-standard": "^12.1",
-        "vimeo/psalm": "^6"
+        "vimeo/psalm": "^6.12"
     },
     "scripts": {
         "phpstan": "phpstan analyse",

phpstan.neon

@@ -32,10 +32,6 @@ parameters:
             paths:
                 - tests/AssertIfTrueTest.php
 
-        -
-            identifier: constructor.unusedParameter
-            paths:
-                - src/*
 
         -
             identifier: missingType.iterableValue

src/Assert.php

@@ -14,8 +14,13 @@
 )]
 final class Assert
 {
-    public function __construct(
-        string ...$params
-    ) {
+    /**
+     * @var string[]
+     */
+    public readonly array $params;
+
+    public function __construct(string ...$params)
+    {
+        $this->params = $params;
     }
 }

src/AssertIfFalse.php

@@ -14,8 +14,13 @@
 )]
 final class AssertIfFalse
 {
-    public function __construct(
-        string ...$params
-    ) {
+    /**
+     * @var string[]
+     */
+    public readonly array $params;
+
+    public function __construct(string ...$params)
+    {
+        $this->params = $params;
     }
 }

src/AssertIfTrue.php

@@ -14,8 +14,13 @@
 )]
 final class AssertIfTrue
 {
-    public function __construct(
-        string ...$params
-    ) {
+    /**
+     * @var string[]
+     */
+    public readonly array $params;
+
+    public function __construct(string ...$params)
+    {
+        $this->params = $params;
     }
 }

src/DefineType.php

@@ -12,8 +12,13 @@
 )]
 final class DefineType
 {
-    public function __construct(
-        string ...$types
-    ) {
+    /**
+     * @var string[]
+     */
+    public readonly array $types;
+
+    public function __construct(string ...$types)
+    {
+        $this->types = $types;
     }
 }

src/ImportType.php

@@ -12,8 +12,13 @@
 )]
 final class ImportType
 {
-    public function __construct(
-        string ...$from
-    ) {
+    /**
+     * @var string[]
+     */
+    public readonly array $from;
+
+    public function __construct(string ...$from)
+    {
+        $this->from = $from;
     }
 }

src/Internal.php

@@ -15,8 +15,7 @@
 )]
 final class Internal
 {
-    public function __construct(
-        ?string $namespace = null
-    ) {
+    public function __construct(public readonly ?string $namespace = null)
+    {
     }
 }

src/Method.php

@@ -12,8 +12,13 @@
 )]
 final class Method
 {
-    public function __construct(
-        string ...$methods
-    ) {
+    /**
+     * @var string[]
+     */
+    public readonly array $methods;
+
+    public function __construct(string ...$methods)
+    {
+        $this->methods = $methods;
     }
 }

src/Mixin.php

@@ -12,8 +12,13 @@
 )]
 final class Mixin
 {
-    public function __construct(
-        string ...$classes
-    ) {
+    /**
+     * @var string[]
+     */
+    public readonly array $classes;
+
+    public function __construct(string ...$classes)
+    {
+        $this->classes = $classes;
     }
 }