Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete operation occurs within GET method #47

Open
halfer opened this issue Oct 21, 2014 · 0 comments
Open

Delete operation occurs within GET method #47

halfer opened this issue Oct 21, 2014 · 0 comments

Comments

@halfer
Copy link

halfer commented Oct 21, 2014

The code here indicates that a delete operation can be conducted within a GET operation. This is not ideal, as an automated system (web crawler, link pre-fetcher) might go off and delete things, seemingly at random.

To protect against this, wrap the item list in a POST form and use a submit button for the delete. The handler code needs to be updated to only respond to POST, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant