Apply PER2.0 phpcs (part 1)

Author: SerafimArts

composer.json

@@ -36,7 +36,9 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.6|^10.0",
-        "vimeo/psalm": "^5.22"
+        "phpstan/extension-installer": "^1.4",
+        "phpstan/phpstan": "^1.11",
+        "phpstan/phpstan-strict-rules": "^1.6"
     },
     "autoload-dev": {
         "psr-4": {

phpstan.neon

@@ -0,0 +1,12 @@
+includes:
+  - phar://phpstan.phar/conf/bleedingEdge.neon
+parameters:
+  level: 1
+  strictRules:
+    allRules: true
+  fileExtensions:
+    - php
+  paths:
+    - src
+  tmpDir: vendor/.cache.phpstan
+  reportUnmatchedIgnoredErrors: false

psalm.xml

@@ -279,12 +279,9 @@ protected function wrap(string $pcre): string
         return $this->delimiter . $pcre . $this->delimiter . \implode('', $this->flags);
     }
 
-    /**
-     * @param string|null $token
-     */
     protected function formatException(string $message, string $token = null): string
     {
-        $suffix = \sprintf(' in %s token definition', $token ?: '<unknown>');
+        $suffix = \sprintf(' in %s token definition', $token ?? '<unknown>');
 
         $message = \str_replace('Compilation failed: ', '', $message);
         $message = \preg_replace('/([\w_]+\(\):\h+)/', '', $message);

src/Compiler/PCRECompiler.php

@@ -73,7 +73,7 @@ private function escape(string $value): string
 
     private function inline(string $value): string
     {
-        return (string) (\preg_replace('/\h+/u', ' ', $value) ?? $value);
+        return \preg_replace('/\h+/u', ' ', $value) ?? $value;
     }
 
     private function shouldBeShorten(string $value): bool

src/Token/Renderer.php

@@ -2,35 +2,27 @@
 
 namespace Phplrt\Lexer\Buffer {
 
-    if (
-        !\class_exists(Buffer::class, false)
-        && \class_exists(\Phplrt\Buffer\Buffer::class)
-    ) {
-        /** @psalm-suppress UndefinedClass */
+    if (!\class_exists(Buffer::class, false)
+        && \class_exists(\Phplrt\Buffer\Buffer::class)) {
+        // @phpstan-ignore-next-line
         \class_alias(\Phplrt\Buffer\Buffer::class, Buffer::class);
     }
 
-    if (
-        !\class_exists(ArrayBuffer::class, false)
-        && \class_exists(\Phplrt\Buffer\ArrayBuffer::class)
-    ) {
-        /** @psalm-suppress UndefinedClass */
+    if (!\class_exists(ArrayBuffer::class, false)
+        && \class_exists(\Phplrt\Buffer\ArrayBuffer::class)) {
+        // @phpstan-ignore-next-line
         \class_alias(\Phplrt\Buffer\ArrayBuffer::class, ArrayBuffer::class);
     }
 
-    if (
-        !\class_exists(ExtrusiveBuffer::class, false)
-        && \class_exists(\Phplrt\Buffer\ExtrusiveBuffer::class, false)
-    ) {
-        /** @psalm-suppress UndefinedClass */
+    if (!\class_exists(ExtrusiveBuffer::class, false)
+        && \class_exists(\Phplrt\Buffer\ExtrusiveBuffer::class, false)) {
+        // @phpstan-ignore-next-line
         \class_alias(\Phplrt\Buffer\ExtrusiveBuffer::class, ExtrusiveBuffer::class);
     }
 
-    if (
-        !\class_exists(LazyBuffer::class, false)
-        && \class_exists(\Phplrt\Buffer\LazyBuffer::class)
-    ) {
-        /** @psalm-suppress UndefinedClass */
+    if (!\class_exists(LazyBuffer::class, false)
+        && \class_exists(\Phplrt\Buffer\LazyBuffer::class)) {
+        // @phpstan-ignore-next-line
         \class_alias(\Phplrt\Buffer\LazyBuffer::class, LazyBuffer::class);
     }
 }

src/polyfill.php

@@ -48,8 +48,8 @@ public function testSimpleMultistateExpression(): void
         $result = (new Multistate([
             'string' => [
                 'escaped_quote' => '\\\\"',
-                'quote'         => '"',
-                'char'          => '\w',
+                'quote' => '"',
+                'char' => '\w',
             ],
             'default' => [
                 'quote' => '"'