Remove UsageOfDeprecatedCastRule in favour of it already being implemented in PHPStan via RestrictedMethodUsageExtension

Author: ondrejmirtes

composer.json

@@ -7,7 +7,7 @@
 	],
 	"require": {
 		"php": "^7.4 || ^8.0",
-		"phpstan/phpstan": "^2.1.13"
+		"phpstan/phpstan": "^2.1.15"
 	},
 	"require-dev": {
 		"php-parallel-lint/php-parallel-lint": "^1.2",

phpstan-baseline.neon

@@ -54,6 +54,12 @@ parameters:
 			count: 1
 			path: tests/Rules/Deprecations/TypeHintDeprecatedInFunctionSignatureRuleTest.php
 
+		-
+			message: '#^Accessing PHPStan\\Rules\\RestrictedUsage\\RestrictedUsageOfDeprecatedStringCastRule\:\:class is not covered by backward compatibility promise\. The class might change in a minor PHPStan version\.$#'
+			identifier: phpstanApi.classConstant
+			count: 1
+			path: tests/Rules/Deprecations/UsageOfDeprecatedCastRuleTest.php
+
 		-
 			message: '#^Accessing PHPStan\\Rules\\Classes\\ExistingClassInTraitUseRule\:\:class is not covered by backward compatibility promise\. The class might change in a minor PHPStan version\.$#'
 			identifier: phpstanApi.classConstant

rules.neon

@@ -45,7 +45,6 @@ services:
 
 rules:
 	- PHPStan\Rules\Deprecations\FetchingDeprecatedConstRule
-	- PHPStan\Rules\Deprecations\UsageOfDeprecatedCastRule
 
 conditionalTags:
 	PHPStan\Rules\Deprecations\CallWithDeprecatedIniOptionRule:

src/Rules/Deprecations/RestrictedDeprecatedMethodUsageExtension.php

@@ -68,6 +68,27 @@ public function isRestrictedMethodUsage(
 		}
 
 		$description = $methodReflection->getDeprecatedDescription();
+		if (strtolower($methodReflection->getName()) === '__tostring') {
+			if ($description === null) {
+				return RestrictedUsage::create(
+					sprintf(
+						'Casting class %s to string is deprecated.',
+						$methodReflection->getDeclaringClass()->getName(),
+					),
+					'class.toStringDeprecated',
+				);
+			}
+
+			return RestrictedUsage::create(
+				sprintf(
+					"Casting class %s to string is deprecated.:\n%s",
+					$methodReflection->getDeclaringClass()->getName(),
+					$description,
+				),
+				'class.toStringDeprecated',
+			);
+		}
+
 		if ($description === null) {
 			return RestrictedUsage::create(
 				sprintf(

src/Rules/Deprecations/UsageOfDeprecatedCastRule.php

@@ -2,23 +2,22 @@
 
 namespace PHPStan\Rules\Deprecations;
 
+use PHPStan\Rules\RestrictedUsage\RestrictedUsageOfDeprecatedStringCastRule;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 
 /**
- * @extends RuleTestCase<UsageOfDeprecatedCastRule>
+ * @extends RuleTestCase<RestrictedUsageOfDeprecatedStringCastRule>
  */
 class UsageOfDeprecatedCastRuleTest extends RuleTestCase
 {
 
 	protected function getRule(): Rule
 	{
-		return new UsageOfDeprecatedCastRule(
-			new DeprecatedScopeHelper([new DefaultDeprecatedScopeResolver()]),
-		);
+		return self::getContainer()->getByType(RestrictedUsageOfDeprecatedStringCastRule::class);
 	}
 
-	public function testUsageOfDeprecatedTrait(): void
+	public function testUsageOfDeprecatedCast(): void
 	{
 		require_once __DIR__ . '/data/usage-of-deprecated-cast.php';
 		$this->analyse(
@@ -32,4 +31,12 @@ public function testUsageOfDeprecatedTrait(): void
 		);
 	}
 
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/../../../rules.neon',
+			...parent::getAdditionalConfigFiles(),
+		];
+	}
+
 }