Skip to content

Commit b6a0076

Browse files
committed
Fixed another weird type-specifying bug
1 parent 77ebb85 commit b6a0076

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

src/Type/Doctrine/QueryBuilder/QueryBuilderTypeSpecifyingExtension.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,6 @@ public function specifyTypes(MethodReflection $methodReflection, MethodCall $nod
5757
return new SpecifiedTypes([]);
5858
}
5959

60-
$lowerMethodName = strtolower($node->name->toString());
61-
if (in_array($lowerMethodName, [
62-
'setparameter',
63-
'setparameters',
64-
], true)) {
65-
return new SpecifiedTypes([]);
66-
}
67-
6860
$returnType = ParametersAcceptorSelector::selectFromArgs(
6961
$scope,
7062
$node->args,

tests/Rules/Doctrine/ORM/data/query-builder-dql.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,4 +251,14 @@ public function queryBuilderFromSomewhereElse(): void
251251
$queryBuilder->getQuery();
252252
}
253253

254+
public function anotherWeirdTypeSpecifyingExtensionProblem(): void
255+
{
256+
$queryBuilder = $this->entityManager->createQueryBuilder();
257+
$queryBuilder->select('e')
258+
->from(MyEntity::class, 'e')
259+
->setParameter('test', '123');
260+
261+
$queryBuilder->getQuery();
262+
}
263+
254264
}

0 commit comments

Comments
 (0)