Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airport Lookup #45

Open
FatihKoz opened this issue Feb 1, 2025 · 0 comments
Open

Airport Lookup #45

FatihKoz opened this issue Feb 1, 2025 · 0 comments

Comments

@FatihKoz
Copy link

FatihKoz commented Feb 1, 2025

Acars should be able to use VA Database too for lookups, having only external sources can cause problems like below.

E:0201 16:26:30 Error prefiling: {"type":"https://phpvms.net/errors/validation-exception","title":"Validation Error","details":"An arrival airport is required","status":400,"error":{"status":400,"message":"An arrival airport is required"},"errors":{"arr_airport_id":["An arrival airport is required"]}}
Refit.ApiException: Response status code does not indicate success: 400 (Bad Request).
E:0201 16:26:30 [ERR][Snackbar] Start Error: Error prefiling, "Bad Request" Bad Request
  • Airport is NOT present in vaCentral
  • Airport is NOT present in the sim's default database (as it can be an addon, published with a different code etc.)
  • Airport is present in VA database

Acars should proceed and allow starting the flight if the airport in questions is present in VA's own airports database. It is the responsibility of the pilot and VA admin to organize their airports, have a common installation/scenery support etc.

Also it would be better to make the snackbar error a bit more human readable, like Start Error: Airport not found (ICAO CODE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant