Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beeping even when mute button pressed #13

Open
tramcrazy opened this issue Apr 12, 2021 · 3 comments
Open

Beeping even when mute button pressed #13

tramcrazy opened this issue Apr 12, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@tramcrazy
Copy link

When I press the mute button on the HAT to stop the beeping, it often starts beeping again a few seconds later. Sometimes, I have to press the mute button three times to make it stop beeping, and often it'll start again after an undetermined amount of time. Is this a 'feature' or a bug?

@Gadgetoid
Copy link
Member

This is a feature, if the soil is dry enough that it gets to the alarm level then it'll incessantly beep until it's watered again.

Perhaps it should silence until the level crosses above the alarm level (plus some buffer) and drops back below again 🤔

Right now the only condition for triggering the alarm is that the saturation has fallen below the warning level:

if sat < self.warn_level:

IIRC (it's been a while since I touched this code!) pressing the alarm button twice will silence the alarm outright.

@tramcrazy
Copy link
Author

Yes, having it silence until it goes above the alarm level sounds like a good idea. Perhaps I'll leave this issue open for now (unless you want to close it) so that people know about this.

@Gadgetoid Gadgetoid added documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Apr 12, 2021
@Gadgetoid
Copy link
Member

Sure leave it open, I've added to my TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants