Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use New Architecture Client by Default in TiCDC Binary #1134

Closed
wlwilliamx opened this issue Mar 18, 2025 · 0 comments · Fixed by #1135
Closed

Use New Architecture Client by Default in TiCDC Binary #1134

wlwilliamx opened this issue Mar 18, 2025 · 0 comments · Fixed by #1135
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@wlwilliamx
Copy link
Collaborator

Description

Currently, the TiCDC binary defaults to using the old architecture client, but the new architecture introduces additional configurations that do not exist in the old architecture. As a result, using the old architecture client with the new architecture binary can lead to errors due to missing configurations.

Since the new architecture client is fully compatible with the old architecture, we should modify the TiCDC binary to always use the new architecture client. This change will prevent configuration mismatches while maintaining backward compatibility.

However, for cdc server, we will continue to support both the new and old architectures, with the old architecture remaining the default. Users can still enable the new architecture in the same three ways as before:

  1. Adding the --newarch (or -x) flag when running cdc server
  2. Setting the environment variable: export TICDC_NEWARCH=true
  3. Specifying newarch: true in the server configuration file

Acceptance Criteria:

  • Modify the TiCDC binary to always use the new architecture client
  • Ensure cdc server continues to support both architectures with the old one as the default
  • Users can still enable the new architecture for cdc server using the existing three methods
@wlwilliamx wlwilliamx self-assigned this Mar 18, 2025
@wlwilliamx wlwilliamx added the type/enhancement The issue or PR belongs to an enhancement. label Mar 18, 2025
@ti-chi-bot ti-chi-bot bot closed this as completed in 8176cc8 Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant