Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpe_firewall is not attribute driven on Windows #22

Open
1dustindavis opened this issue Mar 18, 2020 · 5 comments
Open

cpe_firewall is not attribute driven on Windows #22

1dustindavis opened this issue Mar 18, 2020 · 5 comments

Comments

@1dustindavis
Copy link
Member

On Windows, the cpe_firewall cookbook will enable the firewall if it is included in the run list. No attributes need to be set.

At minimum, the windows recipe should only run if node['cpe_firewall']['EnableFirewall'] is true.

@erikng
Copy link
Collaborator

erikng commented Mar 18, 2020

Ugh. So this is hugely problematic for others using your cookbook. If you have a single run list for all machines, now you will have two behaviors for two different operating systems.

Curious why you didn't make it API driven prior to pushing it.

@ChefAustin
Copy link
Contributor

Blame me, @erikng . I'm the one who added the wonky support for Windows. 😛

@erikng
Copy link
Collaborator

erikng commented Mar 18, 2020

I'll blame Nate. Damnit @natewalck!

@natewalck
Copy link

I didn't make this or even commit code to this. Don't blame me! :D

@ChefAustin
Copy link
Contributor

I’ll try to fix this tomorrow if the world doesn’t come to and end. Thanks for merging the other PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants