-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpe_firewall is not attribute driven on Windows #22
Comments
Ugh. So this is hugely problematic for others using your cookbook. If you have a single run list for all machines, now you will have two behaviors for two different operating systems. Curious why you didn't make it API driven prior to pushing it. |
Blame me, @erikng . I'm the one who added the wonky support for Windows. 😛 |
I'll blame Nate. Damnit @natewalck! |
I didn't make this or even commit code to this. Don't blame me! :D |
I’ll try to fix this tomorrow if the world doesn’t come to and end. Thanks for merging the other PR! |
On Windows, the cpe_firewall cookbook will enable the firewall if it is included in the run list. No attributes need to be set.
At minimum, the windows recipe should only run if
node['cpe_firewall']['EnableFirewall']
is true.The text was updated successfully, but these errors were encountered: