Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Req: (U)HD version of mode 11 #3

Open
Boulder08 opened this issue Jun 4, 2020 · 11 comments
Open

Req: (U)HD version of mode 11 #3

Boulder08 opened this issue Jun 4, 2020 · 11 comments

Comments

@Boulder08
Copy link

For example LSFMod uses Removegrain's mode 11 in its process. However, it's known that the 3x3 kernel is too small for (U)HD resolutions as the actual details in the frame are bigger than single pixels. Having a separate mode with a larger kernel would be very useful for various functions.

https://github.com/realfinder/AVS-Stuff/blob/Community/avs%202.5%20and%20up/LSFmod.avsi

@pinterf
Copy link
Owner

pinterf commented Jun 4, 2020

Removegrain is based strictly on 3x3 kernel so a larger kernel would require writing a completely new filter family, so I'd say no. Probably the logic behind modes cannot be applied straight on a new 5x5 kernel, first you have to establish new rules and formula how a 5x5 matrix defines the new central pixel value. Those new modes should be reinvented and tested for usefulness. From the 28 (?) modes of RgTools only a handful is really good and used.

You can experiment with the kernels using Expr, since it supports relative addressing, you can do such things like
"x[-2,-2] x[2,2] min x[-2,2] x[2,-2] min max"
etc..

@Boulder08
Copy link
Author

If I've understood correctly, RemovegrainHD was created to tackle the issue, but source code is probably not available?

@realfinder
Copy link

@pinterf
Copy link
Owner

pinterf commented Feb 23, 2021

yihaaaa :) You know how I love horrible codes.

@pinterf
Copy link
Owner

pinterf commented Feb 23, 2021

First look: it's not that horrible but a bit hard to read (or I was just get used to the coding style). Note that there were no templates lambdas or constexprs at that time.
What's wrong with this plugin, other than it's unmaintainable in its present form?

@realfinder
Copy link

realfinder commented Feb 24, 2021

it's need new stuff (avs 2.6 Colour formats and HBD)

also maybe it need more modes like classic Removegrain so we can replace the old one with it for HD videos

@pinterf
Copy link
Owner

pinterf commented Feb 24, 2021

This filter is avalilable only for median-based modes, not clear which ones are similar to them in classic removegrain.
Required modes then need to be clarified and implemented one by one in the order of importance.

@pinterf
Copy link
Owner

pinterf commented Feb 24, 2021

Not tested at all, algorithm and core unchanged.
https://github.com/pinterf/RemoveGrainHD/releases/

@realfinder
Copy link

thanks, it's seems work fine from quick test

@pinterf
Copy link
Owner

pinterf commented Feb 25, 2021

Avs 2.6 colorspaces added, and now comes a big silence in the project, it would take weeks to go any further from here.

@realfinder
Copy link

thanks, I open discussion about this realfinder/AVS-Stuff#135

realfinder referenced this issue in Dogway/Avisynth-Scripts Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants