-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for visualImpaired
Attribute
#1494
Comments
Could you provide a sample subtitle file with the attribute? |
@JonnyWong16, I'll see if I can get a sample provided (as I currently don't have one myself) by @gotson, who initially brought this to my attention in my repo for Plex Auto Languages. The XML example he shared with me is as follows: <Stream id="121952" streamType="2" default="1" codec="eac3" index="1" channels="2" bitrate="384" language="French" languageTag="fr" languageCode="fra" audioChannelLayout="stereo" requiredBandwidths="384,384,384,384,384,384,384,384" samplingRate="48000" displayTitle="French (EAC3 Stereo)" extendedDisplayTitle="French (EAC3 Stereo)">
</Stream>
<Stream id="121953" streamType="2" selected="1" codec="aac" index="2" channels="2" bitrate="128" language="French" languageTag="fr" languageCode="fra" audioChannelLayout="stereo" profile="lc" requiredBandwidths="129,129,129,129,129,129,129,129" samplingRate="48000" title="AD" visualImpaired="1" displayTitle="French Descriptive (AAC Stereo)" extendedDisplayTitle="AD (French AAC Stereo Descriptive)">
</Stream> However, I’m hoping @gotson can provide an actual file with the required attribute for further validation. |
Wait, is it audio or subtitle? You mention |
Oh my, I just noticed that myself! I’ve been sick and barely getting any sleep this past week, so I’ve been in a bit of a fog and didn’t catch that until now and it even says Guess I should check https://python-plexapi.readthedocs.io/en/latest/modules/media.html#plexapi.media.MediaPartStream and https://python-plexapi.readthedocs.io/en/latest/modules/media.html#plexapi.media.AudioStream instead. |
The XML you provided is enough info. |
Yea at first, I thought it was for Subtitle rather than Audio, but I'm glad you caught that haha. Thanks for adding the attribute check to In the meantime, I've added |
What is your feature request?
Currently, PlexAPI supports the
hearingImpaired
attribute with a boolean member in plexapi.media.SubtitleStream, allowing developers to easily identify and use this information. However, there is no equivalent boolean member for thevisualImpaired
attribute, which would be useful for identifying content designed for visually impaired users, such as those with audio descriptions.I propose adding support for a
visualImpaired
boolean member to make it easier to work with this attribute in PlexAPI, similar to howhearingImpaired
is implemented.Are there any workarounds?
No response
Code Snippets
No response
Additional Context
Adding support for the
visualImpaired
attribute would align PlexAPI with Plex's accessibility features and improve its usability for developers building applications with accessibility in mind.This enhancement would also create parity between
hearingImpaired
andvisualImpaired
attributes, making PlexAPI more consistent and robust.The text was updated successfully, but these errors were encountered: