Added tests

planetarium · Oct 18, 2023 · ed63d79 · ed63d79
1 parent 27ccf30
commit ed63d79
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 18 deletions.
diff --git a/Bencodex.Tests/Misc/ImplicitConversionTest.cs b/Bencodex.Tests/Misc/ImplicitConversionTest.cs
@@ -41,10 +41,10 @@ public void Binary()
         {
             var binary = new Binary(new byte[] { 0x01, 0x02, 0x03 });
 
-            ImmutableArray<byte> immutable = binary;
+            ImmutableArray<byte> immutable = (ImmutableArray<byte>)binary;
             Assert.Equal(immutable, binary.ByteArray);
 
-            byte[] mutable = binary;
+            byte[] mutable = (byte[])binary;
             Assert.Equal(mutable, binary.ToByteArray());
         }
 

diff --git a/Bencodex.Tests/Types/BinaryTest.cs b/Bencodex.Tests/Types/BinaryTest.cs
@@ -27,6 +27,41 @@ public void DefaultConstructor()
             Assert.Empty(default(Binary).ToByteArray());
         }
 
+        [Fact]
+        public void Equality()
+        {
+            byte[] b = new byte[] { 0, 1 };
+            ImmutableArray<byte> i = ImmutableArray.Create(b);
+            Binary x = new Binary(i);
+            object ob = (object)b;
+            object oi = (object)i;
+            object ox = (object)x;
+
+#pragma warning disable CS1718 // Comparison made to same variable
+            Assert.True(x == x);
+            Assert.True(x.Equals(x));
+            Assert.True(x.Equals(ox));
+            Assert.True(ox.Equals(x));
+            Assert.True(ox.Equals(ox));
+#pragma warning restore CS1718
+
+            // Unlike Integer and Text, implicit conversion is not supported.
+            Assert.False(b.Equals(x));
+            Assert.False(i.Equals(x));
+            Assert.False(x.Equals(b));
+            Assert.False(x.Equals(i));
+
+            Assert.False(b.Equals(ox));
+            Assert.False(i.Equals(ox));
+            Assert.False(ox.Equals(b));
+            Assert.False(ox.Equals(i));
+
+            Assert.False(ob.Equals(ox));
+            Assert.False(oi.Equals(ox));
+            Assert.False(ox.Equals(ob));
+            Assert.False(ox.Equals(oi));
+        }
+
         [Fact]
         public void ConstructorTakingImmutableByteArray()
         {
@@ -141,7 +176,7 @@ public void ToByteArray()
         }
 
         [Fact]
-        public void Equality()
+        public void Equality2()
         {
             Assert.Equal(_empty, new Binary(new byte[0]));
             Assert.Equal<IValue>(_empty, new Binary(new byte[0]));

diff --git a/Bencodex/Types/Binary.cs b/Bencodex/Types/Binary.cs
@@ -85,29 +85,21 @@ public Fingerprint Fingerprint
         [Obsolete("Deprecated in favour of " + nameof(Inspect) + "() method.")]
         public string Inspection => Inspect(true);
 
-        public static implicit operator Binary(ImmutableArray<byte> bytes) =>
+        public static explicit operator Binary(ImmutableArray<byte> bytes) =>
             new Binary(bytes);
 
-        public static implicit operator ImmutableArray<byte>(Binary binary) =>
+        public static explicit operator ImmutableArray<byte>(Binary binary) =>
             binary.ByteArray;
 
-        public static implicit operator Binary(byte[] bytes)
-        {
-            return new Binary(bytes);
-        }
+        public static explicit operator Binary(byte[] bytes) =>
+            new Binary(bytes);
 
-        public static implicit operator byte[](Binary binary) =>
+        public static explicit operator byte[](Binary binary) =>
             binary.ToByteArray();
 
-        public static bool operator ==(Binary left, Binary right)
-        {
-            return left.Equals(right);
-        }
+        public static bool operator ==(Binary left, Binary right) => left.Equals(right);
 
-        public static bool operator !=(Binary left, Binary right)
-        {
-            return !left.Equals(right);
-        }
+        public static bool operator !=(Binary left, Binary right) => !left.Equals(right);
 
         /// <summary>
         /// Creates a new <see cref="Binary"/> instance from a binary turned into