Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline Binary equality and comparison #110

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

greymistcube
Copy link
Contributor

@greymistcube greymistcube commented Oct 18, 2023

Unlike Integer and Text, Binary equality/comparison have been modified to be less convenient.

  • Equality of two Binary instances behave "as expected" (element-wise equality).
  • No longer supports equality checking of Binary, byte[], and ImmutableArray<byte>. The rationale being, one generally does not expect two array/list to be equal because the sequence of elements are the same. Generic equality usually refers to having the same reference for two objects. This is pretty standard across many programming languages including even javascript and python. Such functionality is generally provided by a separate method.
  • Another reason for the change mentioned above is that there is no way to implement consistent equality while providing the convenience(?) necessary due to C#'s language limitations.

@greymistcube greymistcube changed the title Refactor/binary equality Streamline Binary equality Oct 18, 2023
@greymistcube greymistcube changed the title Streamline Binary equality Streamline Binary equality and comparison Oct 18, 2023
@greymistcube greymistcube force-pushed the refactor/binary-equality branch from ed63d79 to f338843 Compare October 19, 2023 02:47
@greymistcube greymistcube self-assigned this Oct 19, 2023
@greymistcube greymistcube requested a review from moreal October 19, 2023 03:25
@greymistcube greymistcube force-pushed the refactor/binary-equality branch from f338843 to f8863b5 Compare October 19, 2023 05:49
@greymistcube greymistcube marked this pull request as ready for review October 19, 2023 05:49
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Show resolved Hide resolved
@greymistcube greymistcube force-pushed the refactor/binary-equality branch from f8863b5 to e4aaa25 Compare October 19, 2023 06:57
@greymistcube greymistcube force-pushed the refactor/binary-equality branch from e4aaa25 to df50054 Compare October 19, 2023 06:58
@greymistcube greymistcube requested a review from moreal October 19, 2023 07:01
@greymistcube greymistcube merged commit f7f265d into planetarium:main Oct 19, 2023
3 checks passed
@greymistcube greymistcube deleted the refactor/binary-equality branch October 19, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants