Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added lists view and two ways to navigate to it #1726

Merged
merged 5 commits into from
Jan 11, 2025
Merged

added lists view and two ways to navigate to it #1726

merged 5 commits into from
Jan 11, 2025

Conversation

bryanmontz
Copy link
Contributor

@bryanmontz bryanmontz commented Jan 8, 2025 •
edited
Loading

Issues covered

https://github.com/verse-pbc/issues/issues/133

Description

Adds the Lists view and two ways to navigate to it.

How to test

A:

  1. Navigate to side menu
  2. Tap Lists

B:

  1. Navigate to Feed tab
  2. Tap the filter button at the top right
  3. Tap the Lists tab
  4. If you have lists already, tap the Manage Your Lists button at the bottom.

Screenshots/Video

Entry point 1:
Bob_s_Phone

Entry point 2:
Bob_s_Phone

Your Lists:
Bob_s_Phone

No Content:
Bob_s_Phone

Pop-up menu:
Bob_s_Phone

@bryanmontz bryanmontz self-assigned this Jan 8, 2025
@bryanmontz bryanmontz marked this pull request as draft January 8, 2025 14:47
@bryanmontz bryanmontz changed the base branch from main to feature/edit-lists-ui January 9, 2025 14:02
@bryanmontz bryanmontz marked this pull request as ready for review January 9, 2025 14:02
@joshuatbrown
Copy link
Contributor

👀

joshuatbrown
joshuatbrown approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks amazing and works perfectly!

Nos/Views/Lists/ListsView.swift Outdated
let author: Author
}

struct ListsView: View {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love a doc comment here, especially since this ListsView might be understood to be a "view of List views" or something. I wonder if AuthorListsView might clarify and avoid that potential confusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Done.

@bryanmontz
Copy link
Contributor Author

Thanks for review and kind words, @joshuatbrown!

@bryanmontz bryanmontz merged commit 4d05623 into feature/edit-lists-ui Jan 11, 2025
4 checks passed
@bryanmontz bryanmontz deleted the bdm/lists-view branch January 11, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuatbrown joshuatbrown joshuatbrown approved these changes

@mplorentz mplorentz Awaiting requested review from mplorentz mplorentz is a code owner

@pelumy pelumy Awaiting requested review from pelumy pelumy is a code owner

Assignees

@bryanmontz bryanmontz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanmontz @joshuatbrown