Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added list detail view #155 #1736

Open
wants to merge 2 commits into
base: feature/edit-lists-ui
Choose a base branch
from

Conversation

bryanmontz
Copy link
Contributor

Issues covered

https://github.com/verse-pbc/issues/issues/155

Description

Adds a list detail view. Also, per design discussions with @Chardot, this PR removes the ellipsis buttons from the "list of lists" view in favor of a similar button in the navigation bar at top right on the new list detail view.

How to test

  1. Navigate to the side menu.
  2. Tap "Your Lists".
  3. Tap on a list.

Screenshots/Video

Bob_s_Phone

list-detail

@joshuatbrown
Copy link
Contributor

👀

Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great! I did notice that when I edit a List Name and Save, the name is updated but the people on the list disappear. I assume that's unrelated to what's in this PR but wanted to point it out just in case. Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants