Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the entrypoint in "edit" does not work #808

Open
mcollina opened this issue Jul 18, 2024 · 7 comments
Open

Changing the entrypoint in "edit" does not work #808

mcollina opened this issue Jul 18, 2024 · 7 comments
Assignees
Labels

Comments

@mcollina
Copy link
Member

No description provided.

@tonysnowboardunderthebridge
Copy link
Contributor

Schermata 2024-07-18 alle 11 42 30

UI passed the following object on update, updating the name of entrypoint

{
    "projectName": "test-808",
    "services": [
        {
            "name": "pippo",
            "template": "@platformatic/composer",
            "fields": [],
            "plugins": []
        },
        {
            "name": "paperino",
            "template": "@platformatic/service",
            "fields": [],
            "plugins": []
        },
        {
            "name": "pluto",
            "template": "@platformatic/service",
            "fields": [],
            "plugins": []
        }
    ],
    "entrypoint": "pluto",
    "port": "3042",
    "logLevel": "info",
    "typescript": true,
    "createGitHubRepository": false,
    "installGitHubActions": false
}


but there is no change on the UI, also after closing meraki and opening again the application

Schermata 2024-07-18 alle 11 51 47

@marcopiraccini
Copy link
Contributor

marcopiraccini commented Jul 18, 2024

I think that the problem is that we don't pass the entrypoint to the generator, see: https://github.com/platformatic/meraki/blob/main/src/main/generate.mjs#L163

@leorossi there is a reason why we are not passing it in the "update" case? Just passing it will solve the issue?

@leorossi
Copy link
Contributor

Seems like that only this is needed: platformatic/platformatic#2849

When this lands, I will update meraki with the latest platformatic release

@mcollina
Copy link
Member Author

@leorossi is there work left to do for this?

@leorossi
Copy link
Contributor

Just a new release of Platformatic

@mcollina
Copy link
Member Author

That was done

@marcopiraccini
Copy link
Contributor

This needs a change on Meraki too

@marcopiraccini marcopiraccini self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants