Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When changing rows always use concat instead of plain reassignment #22

Open
plocket opened this issue May 31, 2021 · 0 comments
Open

When changing rows always use concat instead of plain reassignment #22

plocket opened this issue May 31, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@plocket
Copy link
Owner

plocket commented May 31, 2021

It'll be more robust to future changes if we do rows = rows.concat(... instead of just re-doing rows = parse.fliter(....

should line 259 below now say rows.concat?

Originally posted by @niharikasingh in #20 (comment)
@plocket plocket added the good first issue Good for newcomers label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plocket