Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Feature" text is prepended by a space in downloaded file #27

Open
plocket opened this issue Jun 3, 2021 · 1 comment
Open

Fix "Feature" text is prepended by a space in downloaded file #27

plocket opened this issue Jun 3, 2021 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@plocket
Copy link
Owner

plocket commented Jun 3, 2021

[Does not seem to break tests, so it's not a bug]

Hmm... not sure why this is happening, but in the downloaded file for me, the "Feature" text is prepended by a space. Not essential to fix or anything, but it's just weird.

Originally posted by @niharikasingh in #24 (comment)

Indentation might matter, so we should look into this more deeply.

@plocket
Copy link
Owner Author

plocket commented Dec 10, 2021

Maybe try changing data:text/plain, ${ encodeURIComponent( download_contents )} to data:text/plain,${ encodeURIComponent( download_contents )}

That is, remove the space between data:text/plain, and ${...

@plocket plocket added the help wanted Extra attention is needed label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant