Skip to content

Commit e510c6d

Browse files
Prevent swallowing of ValueError in core.py
Traceback that this leads to: ``` File .../python3.9/site-packages/plotly/express/_core.py:2226, in make_figure(args, constructor, trace_patch, layout_patch) 2223 if args.get("marginal_y") is not None: 2224 ncols += 1 -> 2226 fig = init_figure( 2227 args, subplot_type, frame_list, nrows, ncols, col_labels, row_labels 2228 ) 2230 # Position traces in subplots 2231 for frame in frame_list: File .../python3.9/site-packages/plotly/express/_core.py:2373, in init_figure(args, subplot_type, frame_list, nrows, ncols, col_labels, row_labels) 2370 _spacing_error_translator(e, "Vertical", "facet_row_spacing") 2372 # Remove explicit font size of row/col titles so template can take over -> 2373 for annot in fig.layout.annotations: 2374 annot.update(font=None) 2376 return fig UnboundLocalError: local variable 'fig' referenced before assignment ```
1 parent 00c18fd commit e510c6d

File tree

1 file changed

+1
-0
lines changed
  • packages/python/plotly/plotly/express

1 file changed

+1
-0
lines changed

packages/python/plotly/plotly/express/_core.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2368,6 +2368,7 @@ def _spacing_error_translator(e, direction, facet_arg):
23682368
except ValueError as e:
23692369
_spacing_error_translator(e, "Horizontal", "facet_col_spacing")
23702370
_spacing_error_translator(e, "Vertical", "facet_row_spacing")
2371+
raise
23712372

23722373
# Remove explicit font size of row/col titles so template can take over
23732374
for annot in fig.layout.annotations:

0 commit comments

Comments
 (0)