Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IsLayoutReflowOnTop flag on vertical section #1616

Open
1 task done
nicolaor opened this issue Feb 28, 2025 · 0 comments
Open
1 task done

Support for IsLayoutReflowOnTop flag on vertical section #1616

nicolaor opened this issue Feb 28, 2025 · 0 comments

Comments

@nicolaor
Copy link

nicolaor commented Feb 28, 2025

Category

  • Bug

Describe the bug

There is an attribute "IsLayoutReflowOnTop" on a vertical section that allows the vertical section to reposition to the top on small screens. This attribute is currently not handled in pnp.core.

This is how the page on small screens looks like when the flag is active (the vertical section flows to the top):

Image

This is how the page on small screens looks like when the flag is not active

Image

Steps to reproduce

  1. Create a new Page
    1.1 Add Vertical Section with a webpart in it
    1.2 Add One Column Section with Text
    1.3 Configure the Vertical Section to reposition to the top (IsLayoutReflowOnTop = true)

  2. Load the page using pnp.core
    var page = (await pnpSiteContext.Web.GetPagesAsync("TestPage")).FirstOrDefault()

  3. Save the page as template using pnp.core
    await page.SaveAsTemplateAsync("NewPage.aspx");

Expected behavior

In the template page, the Vertical section on small screens should be positioned to the top, same as in the original page.

Environment details (development & target environment)

PnP.Core version 1.14
.NET 8

Additional context

The attribute IsLayoutReflowOnTop is missing in the pnp.core model and therefore not handled.
I have already implemented a fix for this and ask you to kindly review/merge it.

Thanks for your contribution! Sharing is caring.

nicolaor added a commit to MondayCoffee/pnpcore that referenced this issue Feb 28, 2025
nicolaor added a commit to MondayCoffee/pnpcore that referenced this issue Mar 4, 2025
…on - Add public method to set the property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant