You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is an attribute "IsLayoutReflowOnTop" on a vertical section that allows the vertical section to reposition to the top on small screens. This attribute is currently not handled in pnp.core.
This is how the page on small screens looks like when the flag is active (the vertical section flows to the top):
This is how the page on small screens looks like when the flag is not active
Steps to reproduce
Create a new Page
1.1 Add Vertical Section with a webpart in it
1.2 Add One Column Section with Text
1.3 Configure the Vertical Section to reposition to the top (IsLayoutReflowOnTop = true)
Load the page using pnp.core var page = (await pnpSiteContext.Web.GetPagesAsync("TestPage")).FirstOrDefault()
Save the page as template using pnp.core await page.SaveAsTemplateAsync("NewPage.aspx");
Expected behavior
In the template page, the Vertical section on small screens should be positioned to the top, same as in the original page.
The attribute IsLayoutReflowOnTop is missing in the pnp.core model and therefore not handled.
I have already implemented a fix for this and ask you to kindly review/merge it.
Thanks for your contribution! Sharing is caring.
The text was updated successfully, but these errors were encountered:
nicolaor
added a commit
to MondayCoffee/pnpcore
that referenced
this issue
Feb 28, 2025
Category
Describe the bug
There is an attribute "IsLayoutReflowOnTop" on a vertical section that allows the vertical section to reposition to the top on small screens. This attribute is currently not handled in pnp.core.
This is how the page on small screens looks like when the flag is active (the vertical section flows to the top):
This is how the page on small screens looks like when the flag is not active
Steps to reproduce
Create a new Page
1.1 Add Vertical Section with a webpart in it
1.2 Add One Column Section with Text
1.3 Configure the Vertical Section to reposition to the top (IsLayoutReflowOnTop = true)
Load the page using pnp.core
var page = (await pnpSiteContext.Web.GetPagesAsync("TestPage")).FirstOrDefault()
Save the page as template using pnp.core
await page.SaveAsTemplateAsync("NewPage.aspx");
Expected behavior
In the template page, the Vertical section on small screens should be positioned to the top, same as in the original page.
Environment details (development & target environment)
PnP.Core version 1.14
.NET 8
Additional context
The attribute IsLayoutReflowOnTop is missing in the pnp.core model and therefore not handled.
I have already implemented a fix for this and ask you to kindly review/merge it.
Thanks for your contribution! Sharing is caring.
The text was updated successfully, but these errors were encountered: