Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Error" field in response is not JSON RPC 2.0 compliant #36

Open
phrenciuc opened this issue Jan 22, 2017 · 2 comments
Open

"Error" field in response is not JSON RPC 2.0 compliant #36

phrenciuc opened this issue Jan 22, 2017 · 2 comments

Comments

@phrenciuc
Copy link

First of all congrats for this great extension!

Trying to send some details about the error to the client, I found out that the "error" field in response is automatically casted to string ( see. connection.js:104 ), although the "error" field in JSON RPC 2.0 should be an object (see http://www.jsonrpc.org/specification#error_object ) with "message", "code" and "data" subfields.

@pocesar
Copy link
Owner

pocesar commented Jan 24, 2017

indeed @phrenciuc, the canonical errors (and error codes) were introduced in a patch but they wasn't implemented (although they ARE passed to the error handler), but the code and the data fields are indeed dropped

@giovannigenna
Copy link

when you think that the patch will be available ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants