Wrong copyright statement

[navytux]

Hello up there.

I'm having a brief look at this project and noticed that in some of the places the copyright statement is not ok. Please find details below.

Describe the bug

The copyright statement in e.g. src/bench/rpc_mempool.cpp says:

Copyright (c) 2011-2019 The Pocketcoin Core developers

pocketnet.core/src/bench/rpc_mempool.cpp

Lines 1 to 3 in 28a32e5

	// Copyright (c) 2011-2019 The Pocketcoin Core developers
	// Distributed under the MIT software license, see the accompanying
	// file COPYING or http://www.opensource.org/licenses/mit-license.php.

However the content of that file is clearly derived from similarly-named file in Bitcoin project:

https://github.com/bitcoin/bitcoin/blob/85f96b01b77b779dba71b906d73e0e4a3f84b330/src/bench/rpc_mempool.cpp

who's copyright reads differently:

// Copyright (c) 2011-2022 The Bitcoin Core developers

The git history of this file inside Bitcoin dates back to 2019 and has many edits:

https://github.com/bitcoin/bitcoin/commits/master/src/bench/rpc_mempool.cpp

The git history of this file inside Pocketnet.core dates back to 2021 and has only one revision:

https://github.com/pocketnetteam/pocketnet.core/commits/0.22/src/bench/rpc_mempool.cpp

Given that Pocketcoin.core clearly derives from Bitcoin project (see initial commit bf79d5f where there are many files added with e.g. Copyright (c) 2009-2010 Satoshi Nakamoto (src/addrdb.cpp, src/wallet/wallet.cpp, etc)), it looks like the copyright statement in src/bench/rpc_mempool.cpp on Pocketnet.core is incorrect.

There are several other files with similar sympthoms.

Could you please either correct the copyright throughout the tree to match reality, or clarify that my analysis is wrong and indeed the copyright of the above mentioned file is indeed held by Pocketcoin Core developers not the Bitcoin Core developers.

Thanks beforehand,
Kirill

[andyoknen]

Hi. I think you're right, the copyright needs to be fixed. I suppose this is due to the automatic renaming of Bitcoin -> Pocketcoin, which I have already regretted many times :)

I am currently busy implementing i2pd into the project, after this task I will try to do copyright (I think it will take quite a lot of time)

[navytux]

Thanks for feedback and confirming.