feat: Start of Series.index_of(), for primitive numeric types #19894
Conversation
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19894 +/- ##
===========================================
+ Coverage 59.38% 79.52% +20.14%
===========================================
Files 1554 1558 +4
Lines 215612 216644 +1032
Branches 2452 2456 +4
===========================================
+ Hits 128035 172283 +44248
+ Misses 87019 43804 -43215
+ Partials 558 557 -1 ☔ View full report in Codecov by Sentry. |
itamarst
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa,
wence- and
orlp
as code owners
| dtype if dtype.is_unsigned_integer() => value.cast(&DataType::UInt64), | ||
| dtype if dtype.is_float() => value.cast(&DataType::Float64), | ||
| DataType::Null => AnyValue::Null, | ||
| _ => unimplemented!("index_of() not yet supported for dtype {:?}", value_dtype), |
There was a problem hiding this comment.
The other types (except boolean) can go into the row-encoding and use the branch for binary data.
There was a problem hiding this comment.
I don't really understand what this means, could you expand a little? (I will probably do those in separate PR, but still good to start that with the right approach to save time.)
There was a problem hiding this comment.
I think it should be in one go, as I think it can all go to a single generic impl.
There was a problem hiding this comment.
The row-encoding is used in multi-key group-bys/joins and joins on nested types. I would recommend reading in the join dispatch. Can give a bit more pointers, if you get lost. :)
First part of #5503.
Next steps, in follow-up PRs: