Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add maintain_order parameter to joins #20026

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

stijnherfst
Copy link
Collaborator

@stijnherfst stijnherfst commented Nov 27, 2024

The API docs specify the ordering for left joins as preserving the order of the left Dataframe. In some cases it can be useful to also have this property for other types of joins and in other cases having no required ordering can allow for performance optimizations.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 89.88764% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (0b1d520) to head (05aed8c).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/conversion/mod.rs 53.84% 6 Missing ⚠️
crates/polars-ops/src/frame/join/mod.rs 96.66% 2 Missing ⚠️
crates/polars-ops/src/frame/join/args.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20026      +/-   ##
==========================================
+ Coverage   79.49%   79.52%   +0.02%     
==========================================
  Files        1556     1563       +7     
  Lines      216407   217248     +841     
  Branches     2456     2461       +5     
==========================================
+ Hits       172043   172776     +733     
- Misses      43806    43913     +107     
- Partials      558      559       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/polars-lazy/src/frame/mod.rs Outdated Show resolved Hide resolved
crates/polars-lazy/src/frame/mod.rs Outdated Show resolved Hide resolved
crates/polars-ops/src/frame/join/args.rs Outdated Show resolved Hide resolved
py-polars/polars/dataframe/frame.py Outdated Show resolved Hide resolved
py-polars/polars/lazyframe/frame.py Outdated Show resolved Hide resolved
crates/polars-ops/src/frame/join/args.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants