Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key down navigation is not scrolling in view if list is overflowing #74

Open
Felixclement opened this issue Feb 17, 2021 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@Felixclement
Copy link
Contributor

When using arrows to select options that are overflowing the menu does not scroll into view of the current option

@jackkoppa jackkoppa added bug Something isn't working good first issue Good for newcomers and removed good first issue Good for newcomers labels Feb 22, 2021
@jackkoppa
Copy link
Contributor

Great call, @Felixclement - we'll discuss & hopefully get this worked on. We've already got listeners for keyboard events, obviously, so perhaps there's a "simple" addition of maintaining scroll visibility if the key is an up or down navigation

@jackkoppa
Copy link
Contributor

@ikniaziuk ikniaziuk self-assigned this Mar 17, 2021
@jackkoppa
Copy link
Contributor

jackkoppa commented Mar 19, 2021

Hey @Felixclement, this is fixed w/ #82 & v0.13.1 - mind trying it out??

@jackkoppa jackkoppa assigned Felixclement and unassigned ikniaziuk Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants