Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 support in CI #21

Open
PaTara43 opened this issue Dec 9, 2024 · 7 comments
Open

Add Python 3.13 support in CI #21

PaTara43 opened this issue Dec 9, 2024 · 7 comments

Comments

@PaTara43
Copy link

PaTara43 commented Dec 9, 2024

It seems like the runners don't automatically use Python 3.13, but htere is a way to add support manually (e.g. this and this). Are there any limitations on adding that? If not, is it possible to do so? Same goes for https://github.com/polkascan/py-ed25519-bindings and https://github.com/polkascan/py-sr25519-bindings
Thanks!

p.s. perhaps, the find-interpreter arg may be kept, but python version added on the previous step (source)

steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
  with:
    python-version: '>=3.9 <3.14'
- run: python my_script.py
@arjanz
Copy link
Member

arjanz commented Dec 9, 2024

I also suspect the PyO3 version is a bit outdated, which prevents compiling for 3.13. I will have to look into that as well.

@arjanz
Copy link
Member

arjanz commented Dec 9, 2024

At least https://github.com/polkascan/py-sr25519-bindings needs some refactoring because of deprecated PyO3 version

@arjanz
Copy link
Member

arjanz commented Dec 9, 2024

Updated PyO3 and released, not many code changes needed: https://pypi.org/project/py-bip39-bindings/0.2.0/

@arjanz
Copy link
Member

arjanz commented Dec 9, 2024

https://github.com/polkascan/py-sr25519-bindings is not that easy unfortunately, too outdated code. More thorough rework is required there.

@PaTara43
Copy link
Author

PaTara43 commented Dec 9, 2024

Awesome news! We'll check it out tommorrow. Any thoughts on https://github.com/polkascan/py-ed25519-bindings?

Thank you!

@arjanz
Copy link
Member

arjanz commented Dec 10, 2024

Awesome news! We'll check it out tommorrow. Any thoughts on https://github.com/polkascan/py-ed25519-bindings?

Thank you!

You mean https://github.com/polkascan/py-ed25519-zebra-bindings/ ? That was also easy to upgrade, released: https://github.com/polkascan/py-ed25519-zebra-bindings/releases/tag/v1.2.0

@PaTara43
Copy link
Author

Hey! Just to let you know, it works perfect on Ubuntu 24.04 server with Python 3.13 on RPi 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants