Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version being checked on export instead of import #254

Open
jacobgkau opened this issue Feb 25, 2025 · 0 comments
Open

Version being checked on export instead of import #254

jacobgkau opened this issue Feb 25, 2025 · 0 comments

Comments

@jacobgkau
Copy link
Member

The string error-unsupported-keymap is presumably supposed to be shown when importing a keyboard map created with a newer version of the program. However, the version number check currently occurs in the export function instead of the import function:

if keymap.version != 1 {

The version number is hard-coded to 1 in the export function, which means that "if" statement's checking a const and will never be triggered:

Modifying an exported JSON file so it has some other version number and then importing it does not show the error message (when it presumably should).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant