Skip to content

Commit 61b7969

Browse files
Karina LitskevichEkaterina Sokolova
authored andcommitted
[PGPRO-13969] Fix a problem with isolation tests in v12 and v13 when using pgxs
Before commit 2203ede9 in PG14 running isolation test using PGXS was not working - an error occurred. This is a hack to avoid the error. Tags: rum
1 parent 065accd commit 61b7969

File tree

1 file changed

+19
-10
lines changed

1 file changed

+19
-10
lines changed

Makefile

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,6 @@ ISOLATION_OPTS = --load-extension=rum
3535
EXTRA_CLEAN = pglist_tmp
3636

3737
ifdef USE_PGXS
38-
39-
# We cannot run isolation test for versions 12,13 in PGXS case
40-
# because 'pg_isolation_regress' is not copied to install
41-
# directory, see src/test/isolation/Makefile
42-
ifeq ($(MAJORVERSION),$(filter 12% 13%,$(MAJORVERSION)))
43-
undefine ISOLATION
44-
undefine ISOLATION_OPTS
45-
endif
46-
4738
PG_CONFIG = pg_config
4839
PGXS := $(shell $(PG_CONFIG) --pgxs)
4940
include $(PGXS)
@@ -57,6 +48,24 @@ endif
5748
$(EXTENSION)--$(EXTVERSION).sql: rum_init.sql
5849
cat $^ > $@
5950

51+
#
52+
# On versions 12 and 13 isolation tests cannot be run using pgxs.
53+
# Override installcheck target to avoid the error. This is just a
54+
# shortcut version of installcheck target from pgxs.mk that runs
55+
# all other tests besides isolation tests.
56+
#
57+
ifdef USE_PGXS
58+
ifeq ($(MAJORVERSION), $(filter 12% 13%, $(MAJORVERSION)))
59+
installcheck: submake $(REGRESS_PREP)
60+
ifdef REGRESS
61+
$(pg_regress_installcheck) $(REGRESS_OPTS) $(REGRESS)
62+
endif
63+
ifdef TAP_TESTS
64+
$(prove_installcheck)
65+
endif
66+
endif
67+
endif
68+
6069
ifeq ($(MAJORVERSION), 9.6)
6170
# arrays are not supported on 9.6
6271
else
@@ -99,4 +108,4 @@ isolationcheck: | submake-isolation submake-rum temp-install
99108
$(pg_isolation_regress_check) \
100109
--temp-config $(top_srcdir)/contrib/rum/logical.conf \
101110
$(ISOLATIONCHECKS)
102-
endif
111+
endif

0 commit comments

Comments
 (0)