Skip to content

Drop date from version message? #127

Closed
@df7cb

Description

@df7cb

psqlodbc/connection.c

Lines 1013 to 1031 in 251c8e8

snprintf(vermsg, sizeof(vermsg), "Driver Version='%s,%s'"
#ifdef WIN32
" linking %d"
#ifdef _MT
#ifdef _DLL
" dynamic"
#else
" static"
#endif /* _DLL */
" Multithread"
#else
" Singlethread"
#endif /* _MT */
#ifdef _DEBUG
" Debug"
#endif /* DEBUG */
" library"
#endif /* WIN32 */
"\n", POSTGRESDRIVERVERSION, __DATE__

Could we drop the __DATE__ there? It's making the build unreproducible (and if the build is reproducible, the build date is of little value). I've been patching this out in the Debian package since 2016 with no complaints: https://salsa.debian.org/postgresql/psqlodbc/-/blob/master/debian/patches/reproducible?ref_type=heads

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions