Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X64 merge module installer fails #49

Open
cubt85iz opened this issue Sep 26, 2024 · 10 comments
Open

X64 merge module installer fails #49

cubt85iz opened this issue Sep 26, 2024 · 10 comments

Comments

@cubt85iz
Copy link

cubt85iz commented Sep 26, 2024

Created a WiX Toolset installation that includes the merge module for the latest version and it appears to be suffering from the same issue that the x64 MSI was experiencing in the issue discussion referenced below.

image

Ref: #6

@davecramer
Copy link
Contributor

well that looks like an error where2 file name are being concatenated. Thanks for the report

@davecramer
Copy link
Contributor

does anyone know what dyoqjjp5.dll is ?

@chrullrich
Copy link
Contributor

A placeholder name generated by WiX because MSI wants to see short (8.3) file names in some places.

@cubt85iz
Copy link
Author

cubt85iz commented Sep 30, 2024

Side note: Attempting to install the MSI as part of a burn bundle fails as well. It appears as though WiX may be supplying a value for REINSTALLMODE and that causes the following condition to be triggered:

<Custom Action='NoMinorUpgrade' After='FindRelatedProducts'>UPGRADEFOUND AND REINSTALLMODE</Custom>

It doesn't appear that I can override the value provided for REINSTALLMODE either.

The 'REINSTALLMODE' MsiProperty is controlled by the bootstrapper and cannot be authored. (Illegal properties are: 'ACTION', 'ADDLOCAL', 'ADDSOURCE', 'ADDDEFAULT', 'ADVERTISE', 'ALLUSERS', 'REBOOT', 'REINSTALL', 'REINSTALLMODE', or 'REMOVE'.) Remove the MsiProperty element.

Burn bundle install log:

MSI (s) (E4:6C) [07:19:16:587]: PROPERTY CHANGE: Adding MsiLogFileLocation property. Its value is 'C:\Users\phoffman\AppData\Local\Temp\PostgreSQLForRTSO_20240930071822_001_psqlodbc_x64.msi.log'.
MSI (s) (E4:6C) [07:19:16:587]: Command Line: ARPSYSTEMCOMPONENT=1 MSIFASTINSTALL=7 BURNMSIINSTALL=1 REINSTALLMODE=muso REBOOT=ReallySuppress CURRENTDIRECTORY=C:\Users\phoffman\Documents CLIENTUILEVEL=3 MSICLIENTUSESEXTERNALUI=1 CLIENTPROCESSID=5604 

Pretty easy to reproduce outside of creating a burn bundle if you just pass the property to an msiexec command.
image

@ScherzerThomas
Copy link

I can also confirm this error.
I've got it, when i created a single msi from the x86 and x64 msm file.
Does not appear, when creating a x86 only msi from msm

@davecramer
Copy link
Contributor

@chrullrich any thoughts ?

@chrullrich
Copy link
Contributor

chrullrich commented Nov 23, 2024

I will take a look.

The file name problem looks like @cubt85iz may not have run modify_msi.vbs on the finished installer. It is rather unfortunate that this is required; if more reports of this kind emerge the last resort would be to change the file names to 8.3 despite the pain that will bring. [Update: Not so much pain if the long file names are also there.]

@chrullrich
Copy link
Contributor

WFM if modify_msi.vbs is used on the finished MSI.

@chrullrich
Copy link
Contributor

This is fixed by #76 (if that change is viable).

@cubt85iz
Copy link
Author

I will take a look.

The file name problem looks like @cubt85iz may not have run modify_msi.vbs on the finished installer. It is rather unfortunate that this is required; if more reports of this kind emerge the last resort would be to change the file names to 8.3 despite the pain that will bring. [Update: Not so much pain if the long file names are also there.]

Appreciate the reply. Your assumption is correct. I did not execute the modify_msi.vbs script against the merge module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants