Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bus linker for complex arguments #2340

Open
georgwiese opened this issue Jan 14, 2025 · 0 comments
Open

Fix bus linker for complex arguments #2340

georgwiese opened this issue Jan 14, 2025 · 0 comments

Comments

@georgwiese
Copy link
Collaborator

See the workarounds in #2297 and #2339. I'm not really sure what's happening, but undoing these PRs and using these machine with --linker-mode bus reproduces the issue.

github-merge-queue bot pushed a commit that referenced this issue Jan 20, 2025
Same change as #2297. I opened #2340 to track fixing the root cause.

With this change, we can have the BabyBear RISC-V machine with a bus:
```rs
cargo run -r --features plonky3 --bin powdr-rs compile riscv/tests/riscv_data/keccak-o output --field bb
cargo run -r --features plonky3 pil output/keccak.asm -o output -f --field bb --prove-with plonky3 --linker-mode bus
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant