Skip to content

Commit

Permalink
pppd: Remove promptpass plugin
Browse files Browse the repository at this point in the history
This is prompted by a number of factors:

* The handling of privileges and possibly file descriptors is flawed

* In many cases there will be no terminal accessible to the prompter
  program at the point where the prompter is run

* The passwordfd plugin does much the same thing but does it more
  cleanly and securely.

Signed-off-by: Paul Mackerras <[email protected]>
  • Loading branch information
paulusmack committed Oct 18, 2024
1 parent ac269db commit b8d9dbb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 142 deletions.
6 changes: 1 addition & 5 deletions pppd/plugins/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pppd_plugin_LTLIBRARIES = minconn.la passprompt.la passwordfd.la winbind.la
pppd_plugin_LTLIBRARIES = minconn.la passwordfd.la winbind.la
pppd_plugindir = $(PPPD_PLUGIN_DIR)

PLUGIN_CPPFLAGS = -I${top_srcdir}
Expand All @@ -8,10 +8,6 @@ minconn_la_CPPFLAGS = $(PLUGIN_CPPFLAGS)
minconn_la_LDFLAGS = $(PLUGIN_LDFLAGS)
minconn_la_SOURCES = minconn.c

passprompt_la_CPPFLAGS = $(PLUGIN_CPPFLAGS)
passprompt_la_LDFLAGS = $(PLUGIN_LDFLAGS)
passprompt_la_SOURCES = passprompt.c

passwordfd_la_CPPFLAGS = $(PLUGIN_CPPFLAGS)
passwordfd_la_LDFLAGS = $(PLUGIN_LDFLAGS)
passwordfd_la_SOURCES = passwordfd.c
Expand Down
137 changes: 0 additions & 137 deletions pppd/plugins/passprompt.c

This file was deleted.

0 comments on commit b8d9dbb

Please sign in to comment.