Skip to content

Difficulty attributes in multiplayer and playlist extra mod select are not correctly shown #32503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fuyukiSmkw opened this issue Mar 21, 2025 · 4 comments · Fixed by #32669
Closed

Comments

@fuyukiSmkw
Copy link

Type

Cosmetic

Bug description

  • When selecting extra mods in a multiplayer room, the star rating (at the bottom of the mod select screen) are not shown correctly when SR-changing mods are selected.
    • The shown SR seems to be the SR before the last mod is selected/canceled.
    • Other diff attributes are shown correctly.
  • When selecting extra mods in a playlist, all diff attributes (including star rating) are shown as 0.
  • Mod select in song select (both single & multiplayer) displays correct diff attributes.

See the video.

Screenshots or videos

2025-03-22.00-09-16.mp4

Version

2025.321.0-lazer

Logs

compressed-logs.zip

@AmicioEspyy
Copy link

AmicioEspyy commented Mar 21, 2025

edit: I believe the issue is that the updateTrackedBindables() method in BeatmapDifficultyCache.cs is not being called when the first mod is selected...

@zihadmahiuddin
Copy link
Contributor

Doesn't seem to be just for the first mod select. Looks like this is always 1 version late for some reason. So the first mod change doesn't even trigger the callback here, the second change triggers it but the event value corresponds to the first change, then the third change's event value corresponds to the second event, and so on.

@peppy
Copy link
Member

peppy commented Apr 3, 2025

@smoogipoo Probably one for you to have a quick look at (unsure if this was always broken or might be a potential regression)

@smoogipoo
Copy link
Contributor

smoogipoo commented Apr 4, 2025

Looks like it'll be fixed by #32669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants