Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken using Node v18.16.0 & v20.13.1 #1

Open
mrienstra opened this issue Jun 27, 2024 · 3 comments
Open

Broken using Node v18.16.0 & v20.13.1 #1

mrienstra opened this issue Jun 27, 2024 · 3 comments

Comments

@mrienstra
Copy link

mrienstra commented Jun 27, 2024

I didn't have any issue with https://github.com/pqina/pintura-example-nextjs and https://github.com/pqina/pintura-example-react , both were easy to get running locally.

But with this repo, I see "undefined" instead of some of the plugin names (buttons down the left side), and attempting to open the last tool -- presumably "Redact" -- throws an error:

Uncaught runtime errors:
×
ERROR
Cannot read properties of undefined (reading 'filter')
TypeError: Cannot read properties of undefined (reading 'filter')
    at e.$$.update (http://localhost:3000/static/js/bundle.js:86004:7)
    at ga (http://localhost:3000/static/js/bundle.js:61730:14)
    at new ab.util.duration (http://localhost:3000/static/js/bundle.js:86021:16)
    at xr (http://localhost:3000/static/js/bundle.js:61395:10)
    at Zc (http://localhost:3000/static/js/bundle.js:66095:20)
    at Xc (http://localhost:3000/static/js/bundle.js:66130:17)
    at ga (http://localhost:3000/static/js/bundle.js:61730:73)
    at new qc (http://localhost:3000/static/js/bundle.js:66243:14)
    at Array.Xh (http://localhost:3000/static/js/bundle.js:70645:71)
    at Vn (http://localhost:3000/static/js/bundle.js:61225:16)

localhost_3000_ (11)
localhost_3000_ (12)

It was also a little hard to find this repo, a few of the other repos link to it -- see https://github.com/search?q=org%3Apqina%20pintura-example-react-typescript&type=code -- but others do not, and https://pqina.nl/pintura/guide/#examples-panel does not.


Also, it would be nice if all of these example repos had GitHub issues enabled. I also found a (minor) issue with https://github.com/pqina/pintura-example-nextjs (sticker SVGs are missing), but I can't open an issue there. I'd much prefer to give feedback on GitHub repos in the repo itself, rather than figuring out how best to contact PQINA.

@rikschennink
Copy link
Contributor

Weird it seems to run without issues on Stackblitz, I'll run some tests on Monday.

Also, it would be nice if all of these example repos had GitHub issues enabled. I also found a (minor) issue with https://github.com/pqina/pintura-example-nextjs (sticker SVGs are missing), but I can't open an issue there. I'd much prefer to give feedback on GitHub repos in the repo itself, rather than figuring out how best to contact PQINA.

I'll open up the issue trackers.

@rikschennink
Copy link
Contributor

The issue was that it tried to load all plugins instead of only the ones that had their locale loaded. Just fixed.

@rikschennink
Copy link
Contributor

Added link from react repo to this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants