Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeAOT support plans #1218

Open
Sergio0694 opened this issue Mar 30, 2024 · 1 comment · May be fixed by #1222
Open

NativeAOT support plans #1218

Sergio0694 opened this issue Mar 30, 2024 · 1 comment · May be fixed by #1222

Comments

@Sergio0694
Copy link

I saw that this project (which I love and have been using in some of my apps for years!) has just started getting some updates again, and I wanted to ask about the status for NativeAOT support. Just to clarify, this is not me saying "you need to add NativeAOT", but rather just wondering whether any thought has been put into it as whether it's more in the "never going to happen and not planned" or "we want to do this eventually", mostly so that it can help people workinf on new projects makenbetter and decisions on what SQLite wrapper to use in .NET 🙂

I understand that making this fully trim-safe and AOT-safe would be a significant amount of work and adding a new multi-target for .NET 8 (also likely requiring some source generators with eg. interceptors to replace the heavy use of reflection and LINQ expressions), so I'd understand if this was just something that's not being looked into, but figured I'd ask!

Keep up the good work! 😄
@Sergio0694 Sergio0694 linked a pull request Apr 14, 2024 that will close this issue
Open
@Sergio0694
Copy link
Author

Figured I'd take it upon myself to make a PR for this, since I do want to help out (especially given I've been using this library myself for years and I really like it, and I'd love to be able to give back). I've opened #1222 and added all necessary trim/AOT annotations there to make the code fully trim/AOT-safe. Surprisingly enough, it seems like virtually all code can still work with trim and AOT once all the right annotations are in place, so that is awesome 😄

@praeclarum whenever you have time, please take a look and let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add trim/AOT annotations to make code trim/AOT-safe Sergio0694/sqlite-net
1 participant
@Sergio0694