Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__len__(bf) misreports after open(filename) #28

Open
mizvyt opened this issue Jan 13, 2020 · 4 comments
Open

__len__(bf) misreports after open(filename) #28

mizvyt opened this issue Jan 13, 2020 · 4 comments

Comments

@mizvyt
Copy link
Contributor

mizvyt commented Jan 13, 2020

Issue in detail here:
axiak/pybloomfiltermmap#31

A fix is referenced, but I'd like to still think over the options.

@prashnts
Copy link
Owner

this, #38, #31 might all be linked. I'll take a look.

@prashnts
Copy link
Owner

I was able to reproduce this finally, and noticed this stays even after #40. (Using bf.approx_len gets us correct length...) but need to dig deeper.

I reckon the problem might be around self._bf.count_correct and self._bf.elem_count in the cython class.

Which begs the question: why not use approx_len all the time?

@prashnts
Copy link
Owner

@nffdiogosilva
Copy link

nffdiogosilva commented Dec 9, 2020

Can you not merge that patch into your repository and that publish the updated version to the pypi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@nffdiogosilva @prashnts @mizvyt and others