Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty result of lazy component doubles next node #4079

Closed
aleksandrjet opened this issue Jul 24, 2023 · 1 comment
Closed

Empty result of lazy component doubles next node #4079

aleksandrjet opened this issue Jul 24, 2023 · 1 comment
Labels

Comments

@aleksandrjet
Copy link

I found a bug with empty result of lazy component. I could't fix it and opened pr with fallen test.

Perhaps this is not so easy to fix. Maybe add a notice to the documentation, that lazy component requires something to return (not null or empty fragment)?

@JoviDeCroock
Copy link
Member

JoviDeCroock commented Oct 14, 2023

Hmm, yeah this would be indeed quite hard to fix as it seems a general issue with having no matching DOM for a given VNode during a suspended hydration, basically we want to match some kind of DOM to the suspended node while hydration is ongoing. We currently don't really have a way to see that the oldDom pointer has been consumed and that the future result of lazy will be a placeholder i.e. null.

I'll fold this issue in with #4442 as that would holistically fix these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants