Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp level floors on multiformat units #12308

Open
patmmccann opened this issue Oct 9, 2024 · 2 comments
Open

Imp level floors on multiformat units #12308

patmmccann opened this issue Oct 9, 2024 · 2 comments

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Oct 9, 2024

Type of issue

Feature request

Description

openrtb doesn't support a video floor and a banner floor in the same impression object. This causes issues when the floor for the unit defined by the publisher is say $1 and the video bid adjustment is 50% and the banner bid adjustment is 80% to account for the respective discrepencies in each format. This implies the video floor perceived by adapters should be $2 and the banner floor should be $1.25.

Currently 1.25 is sent in this scenario on imp.bidfloor and video bids between 1.25 and 2 are tossed as below the floor, because they get adjusted to less than $1 before they compete.

Prebid should support sending imp.banner.ext.bidfloor, imp.video.ext.bidfloor, imp.banner.ext.bidfloorcur, imp.video.ext.bidfloorcur and the same for native objects on multiformat units when mediatype is an element of the inverse bid adjustment function

TTD is a known supporter of this and Triplelift is a known transmitter of this.

see #9395 for details on floor as a function of inverseBidAdjustment

@dgirardi
Copy link
Collaborator

dgirardi commented Oct 9, 2024

I believe this is mostly on individual adapters, and supported right now

e.g. TTD could set imp.video.ext.bidfloor = bidRequest.getFloor({mediaType: 'video'}).floor

As far as I can tell there's nothing special about the inverse adjustment, if it's set and different for video, it will be taken into account as long as the adapter asks for a video floor

We could consider doing this in ortbConverter but I'm not sure it makes sense if it's not a standard.

@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Oct 9, 2024
@dgirardi
Copy link
Collaborator

dgirardi commented Oct 9, 2024

Correction: there is a particular problem with inverseBidAdjustment; it does not know which mediaType it's adjusting. The api should be updated to inverseBidAdjustment(floor, bidRequest, mediaType)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants