Core & multiple modules: replace deepAccess with optional chaining
#12544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardi
reviewed
Dec 5, 2024
dgirardi
reviewed
Dec 5, 2024
Adding these changes back after review discovered the missing optional chain which was causing test failure in a previous commit.
…optional-chaining
dgirardi
reviewed
Dec 5, 2024
dgirardi
approved these changes
Dec 5, 2024
dgirardi
changed the title
deepAccess with optional chainingdeepAccess with optional chaining
dgirardi
added
the
needs 2nd review
ChrisHuie
removed
the
needs 2nd review
ChrisHuie
approved these changes
Dec 6, 2024
ChrisHuie
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12543
Type of change
Description of change
Replaces usage of
deepAccesswith optional chaining.By no means comprehensive; just some incremental updates. Focuses on low-hanging fruit in
/src/,/libraries/, and a handful of modules we use regularly.