Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adUnit?.pbAdSlot creates "adSlot" key and not pbAdSlot. #810

Open
rBeefrz opened this issue Dec 16, 2024 · 3 comments
Open

adUnit?.pbAdSlot creates "adSlot" key and not pbAdSlot. #810

rBeefrz opened this issue Dec 16, 2024 · 3 comments
Assignees

Comments

@rBeefrz
Copy link

rBeefrz commented Dec 16, 2024

Describe the bug
adUnit?.pbAdSlot defines 'adslot' and not 'pbadslot'.

To Reproduce
Steps to reproduce the behavior:

  1. Prebid-mobile-android-master
  2. Modify one of the gam original activities (say GamOriginalApiDisplayBanner300x250) and add:
   adUnit?.gpid = "/21808260008/prebid_demo_app_original_api_banner_300x250_order"
   adUnit?.pbAdSlot = "/21808260008/prebid_demo_app_original_api_banner_300x250_order"
  1. Run PrebidDemoKotlin & retrieve the request for the 300x250 banner.

Expected behavior
Unless i'm very much mistaken we expect pbAdSlot to define pbadslot in the imp[].ext and not 'adslot', as per here.

Screenshots
image

image

Additional context
Add any other context about the problem here.

@YuriyVelichkoPI
Copy link
Contributor

@OlenaPostindustria please, check the iOS behaviour.

@OlenaPostindustria
Copy link
Collaborator

@YuriyVelichkoPI, iOS SDK creates adslot key as well.

@YuriyVelichkoPI
Copy link
Contributor

@OlenaPostindustria @ValentinPostindustria let's fix it in following way

If the publisher uses property pbAdSlot - add the imp[].ext.data.pbadslot field to the request.

Don't remove the current adslot field from the request. Add warning log message: "Prebid SDK will stop sending imp[].ext.data.adslot" field soon. If you still need it, add a comment to: #810."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

4 participants