-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support collecting arbitrary ORTB parameters #877
Support collecting arbitrary ORTB parameters #877
Comments
Expanded the request to add the response side of the ORTB. |
After discussion, this has been broken into separate issue
|
@bretg It looks like under the ext there is prebid/dlp, skadn, data, keywords, and GPID. Does the object with the arbitrary fields only need to go through if these don't exist or how does it need to go through in the json with things like GPID? |
Not sure I understand the question so let me give a pseudo-code example:
What should get sent in the Prebid Server imp object is:
|
Ah okay, so it just needs to be added under the "data" section in "ext". That answers my question, thanks! |
What I'm saying is that the object supplied on BannerAdUnit needs to be merged at the imp level.
Really anything under "ext" is arbitrary and might change over time. The code that does the merging should be simple and not assume or validate anything other than valid JSON. |
@jsligh - was there a docs PR opened? |
@bretg There’s about to be. The Android PR hasn’t been pushed and there hasn’t
been a new build with this in it yet.
…On Mon, Mar 11, 2024 at 8:41 AM bretg ***@***.***> wrote:
@jsligh <https://github.com/jsligh> - was there a docs PR opened?
—
Reply to this email directly, view it on GitHub
<#877 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBFUGSOC7235PALEKCRWYHLYXW7A3AVCNFSM6AAAAAA2FB4JD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBYGQ3TAMBRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Describe the solution you'd like
Adding Arbitrary ORTB Request Fields
We're building a separate GPID feature in issue #925, but it would be great to be able to pass arbitrary ORTB fields into the request. The SDK could support flexible ORTB entry. e.g.
Where ORTB_OBJECT is an imp-specific block of JSON that can get merged into the PBS request under that imp object as a last step. e.g. in the case of GPID, it would be
{ext: {gpid: "blah"}}
We have to decide the merge precedence for when a JSON block is supplied by both the API and the generic interface. Based on PBS experience, I would suggest something simple like:
Additional context
Prebid.js has supported accepting arbitrary ORTB for a year now and it's worked quite well to handle new use cases.
The text was updated successfully, but these errors were encountered: