Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support For OpenRTB 2.6-202211 #2442

Closed
SyntaxNode opened this issue Oct 31, 2022 · 6 comments
Closed

Support For OpenRTB 2.6-202211 #2442

SyntaxNode opened this issue Oct 31, 2022 · 6 comments
Labels

Comments

@SyntaxNode
Copy link
Contributor

OpenRTB 2.x is changing to a monthly release cadence, as needed. The first monthly release will be for November 2022 with the version designation of "OpenRTB 2.6-202211". This so far includes

  • DOOH (Digital Out Of Home) as a new inventory type alongside App and Site.
  • GPP
  • Imp-Level Exposure Time

The 2.6 spec is now available at https://github.com/InteractiveAdvertisingBureau/openrtb2.x with 2.6-202211 features represented as PRs.

We already have issue #2380 to cover the implementation details of GPP. The Imp-Level Exposure Time is likely just a new field we need to add (imp[].etime).

DOOH will require more effort since PBS has a fair amount of "if app, else site" logic. At a minimum we'll need to add and enforce a new dooh capability along side app and site. Adapters logic is likely fine if we keep dooh support disabled by default so adapters can still safely rely on their "if app, else site" logic. We'll need to find ad update those kind of checks in core functionality.

@SyntaxNode
Copy link
Contributor Author

It doesn't look like imp[].ext.tid will be promoted to imp[].tid in this release.

@bretg bretg moved this from Triage to Needs Requirements in Prebid Server Prioritization Nov 4, 2022
@bretg
Copy link
Contributor

bretg commented Nov 4, 2022

The GPP work will be done as part of #2380

We need to wait for the IAB to finalize the dooh and etime fields before considering this ready-for-dev.

@minaguib
Copy link
Contributor

minaguib commented Jan 16, 2023

Note: The IAB announced November 29th they are moving away from big release versions to incremental updates that facilitate key feature discussion and propagation.

On December 7th the OpenRTB spec was updated to include DOOH support (announcement)

Key to DOOH support is:

  • New BidRequest.dooh object - this is mutually exclusive with existing .site and .app objects
  • New Imp.qty object which includes key DOOH metadata such as the impression multiplier

I would love PBS team feedback on incorporating the above. I generally agree with @SyntaxNode's assessment. Specifically I envision:

  • PBS should upgrade internal OpenRTB data structures to learn new spec objects and relationships
  • PBS should accept incoming requests containing these attributes
  • PBS adapters should, by default without requiring any mass updates, "continue to work" for site and app cases:
    • This means incoming DOOH requests to PBS would not be passed to adapters that do not support them (currently: all)
    • As new DOOH-friendly adapters are added from DOOH SSPs, and/or existing adapters are upgraded to support DOOH, they can start processing these requests
    • Mechanism to express support/interest per adapter?

Note that the "site or app" challenge is not limited to Prebid - the entire OpenRTB ecosystem has had this single "if" engrained for too long - care must be taken for all processors of BidRequests to accommodate the now 3rd mutually exclusive case of DOOH.

@SyntaxNode
Copy link
Contributor Author

SyntaxNode commented Jan 17, 2023

Thank you @minaguib for your input on Digital Out Of Home (DOOH).

PBS-Go uses the prebid/openrtb library which is the official continuation of mxmCherry/openrtb. The prebid/openrtb library fully supports all OpenRTB 2.6-202211 fields including DOOH. However, Prebid Server is not yet aware of DOOH in the same way it is for App and Site. Let's consider this the kick off.

I'm working on this today for PBS-Go to determine exactly which areas of code are impacted.

Adapter code involving "site or app" will not be affected because each adapter already has to opt-in to support specific inventory types via the bidder configuration. Adapters will only receive requests for inventory types they support. When we add the DOOH inventory type all of the adapters will default to not supporting it and continue to work with just app and site.

@SyntaxNode
Copy link
Contributor Author

OpenRTB 2.6-202211 was not yet finalized when this issue was created and there were a few unexpected changes. Here's the complete list:

  • New Object: request.dooh
  • New Object: imp.qty
  • New Field: imp.dt (timestamp when the item is estimated to be fulfilled)
  • New Field: app.inventorypartnerdomain & site.inventorypartnerdomain (a domain to be used for inventory authorization)
  • New Field: regs.gpp
  • New Field: regs.gpp_sid

We have separate issues for tracking

The only other remaining new field we haven't yet discussed is inventorypartnerdomain and if there is any logic for PBS to perform in relation.

@bretg bretg added the PBS-Java label Sep 26, 2023
@bretg bretg moved this from Needs Requirements to In Progress in Prebid Server Prioritization Sep 26, 2023
@bretg
Copy link
Contributor

bretg commented Oct 26, 2023

resolved with PBS-Java 2.1

@bretg bretg closed this as completed Oct 26, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Prebid Server Prioritization Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants