-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress transaction IDs #2727
Comments
Item 4 was discussed in Backlog Grooming. Per recommendation of the Committee, I created a new issue #2794 to discuss how to handle the request id. |
Spoke with the Prebid.js team. They're going to name this activity Would like to discuss in the next committee meeting |
Discussed in PBS committee and agreed on transmitTid |
Flipped back to Needs Requirements until we can discuss the newly proposed request-level flag |
Discussed in committee. There will be two ways of controlling the passing of imp.ext.tid:
The relevant code in Prebid.js is https://github.com/prebid/Prebid.js/blob/e1acefe45a251c49eae3b538b71eea973bf5d860/modules/prebidServerBidAdapter/ortbConverter.js#L78 |
To clarify how this integrates with #2381...
There are two specific tasks tied to the transmitTid activity $.source.tid
$.imp[].ext.tid
Note: there are no changes for |
Updates for prebid/prebid-server#2727
* TID changes Updates for prebid/prebid-server#2727 * linting updates
Done with PBS-Java 2.2 |
In contrast to the buyer-initiated effort to add imp.ext.tid in #2381, we now need to partly walk that change back.
Requirements
source.tid
orimp.ext.tid
to bidders by default.Implementation
We discussed in committee two options for building this feature:
activity
to the "activity infrastructure" being built out as part of PBS GPP phase 3 #2591After discussing these options, a new 'transmitTid' activity has been added to section 3.3.4 of https://docs.google.com/document/d/1dRxFUFmhh2jGanzGZvfkK_6jtHPpHXWD7Qsi6KEugeE/edit#
To support the desire for suppression to be default, the PBJS team would like to send us a behavioral flag:
If this flag is present and false, the code that enforces the transmitTid activity when preparing the bidder requests should remove / not add
source.tid
andimp.ext.tid
.Note that we do not intend to implement a general activity override on the ORTB request due to complexities in determining priority of request-parameters vs the activity config. So this is considered a one-off feature. If at some point we decide that request-level control of activities is a general requirement, there will be a separate set of requirements.
The text was updated successfully, but these errors were encountered: