Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ortb2blocking module issue: concurrent map read and map write #3570

Open
shunj-nb opened this issue Mar 12, 2024 · 0 comments
Open

ortb2blocking module issue: concurrent map read and map write #3570

shunj-nb opened this issue Mar 12, 2024 · 0 comments

Comments

@shunj-nb
Copy link

There is concurrency issue for prebid.ortb2blocking module. below is the error log
concurrent map read and map write 
 goroutine 47540958 [running]:
 github.com/prebid/prebid-server/modules/prebid/ortb2blocking.handleRawBidderResponseHook({{{{{...}, {...}, {...}, {...}}, {0x0, 0x0, 0x0}, {0xc007e2e400, 0x60, 0x8d}, ...}, ...}}, ...)
 /app/msp/submodules/prebid-server/modules/prebid/ortb2blocking/hook_raw_bidder_response.go:21 +0xa5
 github.com/prebid/prebid-server/modules/prebid/ortb2blocking.Module.HandleRawBidderResponseHook({}, {0x15282a0?, 0x5?}, {{0xc00747a700, 0x6dd, 0x700}, {_, _}, _}, {{0xc00775ba70, ...}, ...})
 /app/msp/submodules/prebid-server/modules/prebid/ortb2blocking/module.go:54 +0x206
 github.com/prebid/prebid-server/hooks/hookexecution.(*hookExecutor).ExecuteRawBidderResponseStage.func1({0x16ef640?, 0xc003c42f60?}, {{0xc00747a700, _, _}, {_, _}, _}, {0x7f4a4c44cfc0, 0x1e04b80}, ...)

I don't think we should write to module context in bidder stages(BidderRequest and RawBidderResponse) like this https://github.com/prebid/prebid-server/blob/master/modules/prebid/ortb2blocking/hook_bidderrequest.go#L50. Because bidders are handled in different routines at same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants