Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prebid.org Download PrebidJS page is refering to some modules incorrectly #5636

Closed
pm-harshad-mane opened this issue Sep 12, 2024 · 3 comments
Assignees

Comments

@pm-harshad-mane
Copy link
Contributor

pm-harshad-mane commented Sep 12, 2024

The prebid.org Download PrebidJS page is refering to some modules incorrectly. https://docs.prebid.org/download.html

  • BritePool refers to britepoolIdSystem module that is not present in prebid js repo. Also https://docs.prebid.org/dev-docs/modules/userid-submodules/britepool.html mentions that "britepool is probably a defunct User ID system, as britepool.com is now an e-commerce site."
  • DeepIntent ID module referes to modulecode = deepintentIdSystem whereas actual module code should be deepintentDpesIdSystem @sourabhg
  • Adriver ID, modulecode = adriverId not present in repo

There might be more... how can we automate the validation?
When user selects the Prebid version, we can hide the modules that are not present in https://github.com/prebid/Prebid.js/blob/master/modules/.submodules.json?

@dgirardi
Copy link
Contributor

Related: #5402

@ChrisHuie ChrisHuie self-assigned this Sep 13, 2024
@patmmccann patmmccann transferred this issue from prebid/Prebid.js Sep 25, 2024
@patmmccann
Copy link
Collaborator

One shortcut proposal to solve part of the problem:

Add max version to each adapter and post filter all the adapters with their max version below the download page min version at https://github.com/prebid/prebid.github.io/blob/master/download.md

@patmmccann patmmccann transferred this issue from prebid/prebid.github.io Oct 7, 2024
@patmmccann
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants