Document skipPbsAliasing

[bretg]

There was a workaround added a while back in prebid/Prebid.js#6150 that dealt with an odd scenario where a bidder (MediaFuse) was an alias of one adapter in Prebid.js, but a different adapter in Prebid Server.

So a PBJS bid adapter spec addition was made where aliases can be flagged with 'skipPbsAliasing:true'. The original scenario has been removed, but there are several additional aliases that have this flag, though it's not clear why:

  {code: 'adport', skipPbsAliasing: true},
  {code: 'bidsmind', skipPbsAliasing: true},
  {code: 'mobupps', skipPbsAliasing: true}
modules/adverxoBidAdapter.js
  {code: 'attekmi', skipPbsAliasing: true},
  {code: 'markapp', skipPbsAliasing: true},
  {code: 'jdpmedia', skipPbsAliasing: true},
  {code: 'tredio', skipPbsAliasing: true},
  {code: 'felixads', skipPbsAliasing: true},
  {code: 'vimayx', skipPbsAliasing: true},
modules/smarthubBidAdapter.js
  aliases: ['playwire', 'adlivetech', 'gridNM', { code: 'trustx', skipPbsAliasing: true }],
modules/gridBidAdapter.js

I would like to understand why the skipPbsAliasing flag is needed for these aliases. @TheMediaGrid - seems to me that allowing Prebid.js to alias trustx->grid would be fine nowadays. (?)

@SmartHubSolutions - similar question - none of these aliases exist in Prebid Server, so there should be no harm in having PBJS define the alias.

I think the only reason that skipPbsAliasing should be necessary is for odd scenarios like the original mediafuse issue where there's a transition happening between the alias and base adapter.

[SmartHubSolutions]

Thanks for your attention to our code.
I previously added this option based on description of the possibility to skip passing spec.code to prebid server in request extension.
Thanks for the clarification, I've created a fix: prebid/Prebid.js#12601